Fix mismatched example in sint32 and int64 suites#245
Merged
1 commit merged intomainfrom Sep 4, 2024
unknown repository
Merged
Fix mismatched example in sint32 and int64 suites#2451 commit merged intomainfrom unknown repository
1 commit merged intomainfrom
unknown repository
Conversation
sudorandom
approved these changes
Sep 4, 2024
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In theory this is not a big deal, but the Go implementation actually catches this, since it validates which standard constraints you use. (I feel we should probably include that check in
buf lintas well since presumably we don't yet.)