Merged
Conversation
pkwarren
approved these changes
Mar 2, 2023
pkwarren
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo uses
protocfor verification -- to make sure that things like options interpretation and source code info match what the reference compiler produces.This updates the version of
protocused to the latest release v22.0. This uncovered discrepancies: changes/fixes inprotocthat required changes to protocompile code to match.descriptor.protowas in use. The new v22.0 compiler includes a new field ongoogle.protobuf.EnumOptionswith a tag of 6. It just so happens that the test's override version also had a field with a tag of 6. The new compiler's field is a bool, but the override version's is a string. Since these use incompatible wire type encoding,protoctreats the override field as an unrecognized field, despite it having a known tag. So I've updated the options interpretation code to implement the same logic.protoc.