Fix invalid generation when using in-rule and not_in rule in map.keys.string#847
Merged
rodaine merged 4 commits intobufbuild:mainfrom Apr 24, 2023
Merged
Fix invalid generation when using in-rule and not_in rule in map.keys.string#847rodaine merged 4 commits intobufbuild:mainfrom
rodaine merged 4 commits intobufbuild:mainfrom
Conversation
|
|
Contributor
Contributor
Author
|
Hi @elliotmjackson! I've added some test cases to the PR. |
Contributor
Author
|
Oh, test is failing. I will fix it. |
Contributor
Author
|
@elliotmjackson I fixed tests! |
Contributor
Author
|
@elliotmjackson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I fixed invalid generation for Go and cc when using in-rule and not_in rule in map.keys.string
Issue
Closes #785