cc: Convert base file name to screaming snake case#272
Merged
akonradi merged 4 commits intobufbuild:masterfrom Sep 4, 2019
Merged
cc: Convert base file name to screaming snake case#272akonradi merged 4 commits intobufbuild:masterfrom
akonradi merged 4 commits intobufbuild:masterfrom
Conversation
This patch converts the base file name into screaming snake case instead
of upper for cc macro generation.
This is motivated by:
INFO: From Compiling external/com_github_openzipkin_zipkinapi/zipkin-jsonv2.pb.validate.cc:
In file included from bazel-out/k8-opt/bin/external/com_github_openzipkin_zipkinapi/zipkin-jsonv2.pb.validate.cc:5:
bazel-out/k8-opt/bin/external/com_github_openzipkin_zipkinapi/zipkin-jsonv2.pb.validate.h:37:31: warning: ISO C99 requires whitespace after the macro name [-Wc99-extensions]
^
1 warning generated.
As reported in
envoyproxy/envoy#6985 (comment).
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Contributor
|
Thanks, this is definitely the right way forward. Looks like the |
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
dio
commented
Sep 4, 2019
akonradi
suggested changes
Sep 4, 2019
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
akonradi
approved these changes
Sep 4, 2019
Contributor
|
Looks good, will merge once CI passes |
Contributor
Author
|
Thank you, @akonradi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch converts the base file name into
screaming_snake_caseinsteadof
upperfor cc macro generation.This is motivated by:
As reported in
envoyproxy/envoy#6985 (comment).
Signed-off-by: Dhi Aurrahman dio@tetrate.io