upgrade dependencies and change interval to monthly#48
Merged
Conversation
mfridman
approved these changes
Jul 12, 2022
pkwarren
reviewed
Jul 12, 2022
package.json
Outdated
| "esbuild": "^0.14.48", | ||
| "@types/node": "^18.0.3", | ||
| "esbuild": "^0.14.49", | ||
| "typescript": "^4.7.4" |
Member
There was a problem hiding this comment.
Aren't @types/node, esbuild, and typescript all dev dependencies?
Another option would be to add separate configuration for production vs. development dependencies using dependency-type: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow
Member
Author
There was a problem hiding this comment.
yeh they are, going to move them to dev dependencies
pkwarren
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the PRs that
dependabotcreated recently are just some devDependencies upgrade (mainly eslint/type), and the built code didn't change after the upgrade, so it doesn't seems to be meaningful/worth to upgrade them weekly, instead monthly should be sufficient.