Skip to content

Unbreak CI after #3316#3348

Merged
mcy merged 1 commit intomainfrom
mcy/unbreak
Sep 26, 2024
Merged

Unbreak CI after #3316#3348
mcy merged 1 commit intomainfrom
mcy/unbreak

Conversation

@mcy
Copy link
Copy Markdown
Member

@mcy mcy commented Sep 26, 2024

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 26, 2024, 5:15 PM

Comment thread .golangci.yml
# G404 checks for use of the ordinary non-CPRNG.
path: private/buf/buflsp/progress.go
text: "G404:"
- linters:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doriable can you take a look to see if these exceptions make sense?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep -- so truncating conversions is definitely a known false positive in the issue I put for the G115 exemptions. I went through each one and they are all good. We already have a clear comment for the one in report.go also for converting the version, so this looks good to me.

Comment thread .golangci.yml
# G404 checks for use of the ordinary non-CPRNG.
path: private/buf/buflsp/progress.go
text: "G404:"
- linters:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep -- so truncating conversions is definitely a known false positive in the issue I put for the G115 exemptions. I went through each one and they are all good. We already have a clear comment for the one in report.go also for converting the version, so this looks good to me.

@mcy mcy merged commit fd749ca into main Sep 26, 2024
@mcy mcy deleted the mcy/unbreak branch September 26, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants