Less slice construction/copying thanks to generics#2584
Merged
Conversation
Member
|
Can you fix merge conflicts, and also locally check that this branch cleanly merges into the bufmod branch (but do not push to the bufmod branch)? |
Member
Author
|
@bufdev, done. You can see the results of clean merge to bufmod here: https://github.com/bufbuild/buf/commits/jh/pr-2854+bufmod |
bufdev
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of converting a
[]bufimage.ImageFileor[]*imagev1.ImageFilefirst to a[]protodescriptor.FileDescriptorand then to a[]*descriptorpb.FileDescriptorProto, we can easily elide the first step using generics.So instead of "generic" functions accepting a
[]protodescriptor.FileDescriptor, they use type arguments, so they accept any[]FwhereFimplementsprotodescriptor.FileDescriptor.This allowed for removal of a few no-longer-needed helper functions.