Conversation
mfridman
approved these changes
Aug 2, 2023
Member
mfridman
left a comment
There was a problem hiding this comment.
One endpoint to rule them all.
I don't have much context, but on the surface, it feels odd to slam all the possible search items under one RPC.
Searching within a module seems different than searching across the BSR for resource names.
paul-sachs
reviewed
Aug 2, 2023
| string repository_owner = 2; | ||
| string repository_name = 3; | ||
| string proto_file_path = 4; | ||
| string fully_qualified_name = 5; |
Contributor
There was a problem hiding this comment.
We need to be able to build something like https://buf.build/acme/petapis/docs/main:pet.v1#pet.v1.PetStoreService, we kinda need to package name as well. Unless all fully qualified names can be transformed into package names easily. I'm not sure that's possible.
Member
Author
There was a problem hiding this comment.
added a package name to it
paul-sachs
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.