Conversation
|
Ugh not this problem again...is there any way to "compact" the output smartly? We use json.Compact on protojson output as it does the same non-determinism stuff. |
|
It looks like the way to disable this is in an internal package: |
bufdev
left a comment
There was a problem hiding this comment.
If we're adding the txtpb format, it needs to be added universally instead of just in bufconvert - see the previous PR that changed bin to binpb for all the places that are affected.
|
@bufdev now also integrated into the image encoding formats. |
|
Looks good, let me take one last look tomorrow or Monday to make sure, unless you need merged sooner? |
|
No rush, thanks for the reviews! |
|
Can you bring up a corresponding PR in the buf.build repo to document this as a new format? |
|
This is good to go, but needs the docs ready to go first, should be an easy change |
Note: It appears that the whitespace in the protobuf text is intentionally non-deterministic.