Add beta registry plugin command (remove alpha plugin)#2137
Conversation
bufdev
left a comment
There was a problem hiding this comment.
Assuming moved to registry, LGTM
private/buf/cmd/buf/buf.go
Outdated
| stats.NewCommand("stats", builder), | ||
| migratev1beta1.NewCommand("migrate-v1beta1", builder), | ||
| studioagent.NewCommand("studio-agent", noTimeoutBuilder), | ||
| { |
There was a problem hiding this comment.
Yea I think id still argue to put this under registry...other commands may be bsr-API-specific, but we call the registry command the subcommand to manage BSR assets
There was a problem hiding this comment.
Ye that's fair, we'll first need to remove the existing buf beta registry plugin (now deprecated) set of commands to avoid confusion.
Available Commands:
create Create a Protobuf plugin
delete Delete a Protobuf plugin
list List plugins on the specified BSR
version Manage Protobuf plugin versionsThere was a problem hiding this comment.
You can do this in the same PR - beta commands are inherently unstable
private/buf/cmd/buf/buf.go
Outdated
| "github.com/bufbuild/buf/private/buf/cmd/buf/command/alpha/registry/token/tokenlist" | ||
| "github.com/bufbuild/buf/private/buf/cmd/buf/command/alpha/workspace/workspacepush" | ||
| "github.com/bufbuild/buf/private/buf/cmd/buf/command/beta/migratev1beta1" | ||
| "github.com/bufbuild/buf/private/buf/cmd/buf/command/beta/plugin/plugindelete" |
There was a problem hiding this comment.
Oops, we'll also want to move this under /beta/registry/ for consistency
CHANGELOG.md
Outdated
|
|
||
| - No changes yet. | ||
| - Remove `buf beta registry template` commands. | ||
| - Move `buf alpha plugin` commands to `buf beta registry plugin` and remove old plugin implementation. |
There was a problem hiding this comment.
Maybe be more specific and state that the following old plugin commands are removed:
buf beta registry plugin <create|deprecate|list|undeprecate|version>
and that these commands now work with remote plugins:
buf beta registry plugin <delete|push>
Is it worth also linking to docs somewhere re: custom plugins or the alpha -> remote plugins/packages migration pages?
This PR removes the old
buf alpha plugin {push,delete}commands and moves them tobuf beta registry plugin {push, delete}.Notable changes:
buf.build, instead ofplugins.buf.build(drop subdomain)buf beta registry repository createcommandWe might want to nest theUpdated in 8622c06buf beta plugincommand under registry, likebuf beta registry plugin {push,delete}.. but this is less an API command and more likebuf push, so there's an argument to keep it underbuf beta plugin pushand eventually promote it to justbuf plugin push.Furthermore, theplugin pushcommand calls docker under the hood, so it's not strictly a registry API command.