Conversation
Update the code that reads a buf.lock file from disk to only ignore previous b1/b3 module digests. If the lock file has an invalid manifest digest, we want to error early.
pkwarren
commented
May 22, 2023
|
|
||
| // isValidDigest returns true when the digest string is successfully parsed | ||
| // by the `manifest` pkg. Older buf digests are not considered valid (b1/b3). | ||
| func isValidDigest(digest string) bool { |
Member
Author
There was a problem hiding this comment.
This was too lenient before - it would also ignore a digest field in the newer format that wasn't valid (wrong encoding, length, algorithm, etc.). We only wanted to ignore buf.lock digest values which may have potentially contained a b1/b3 digest value.
unmultimedio
approved these changes
May 23, 2023
saquibmian
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the code that reads a buf.lock file from disk to only ignore previous b1/b3 module digests. If the lock file has an invalid manifest digest, we want to error early.
Fixes #2110.