Author Enhancement#3
Merged
buchanae merged 2 commits intobuchanae:masterfrom Aug 20, 2018
jrnt30:master
Merged
Conversation
Contributor
jrnt30
commented
Aug 17, 2018
- Adds the ability to include the PR author in the change log for some props.
- Additionally adds an explicit flag for github token and defaults to ENV.
- Adds the ability to include the PR author in the change log for some props. - Additionally adds an explicit flag for github token and defaults to ENV.
buchanae
reviewed
Aug 19, 2018
main.go
Outdated
| flag.BoolVar(&conf.IncludeCommits, "include-commits", conf.IncludeCommits, "Include commit messages") | ||
| flag.BoolVar(&conf.SinceLatestRelease, "since-latest-release", conf.SinceLatestRelease, "Stop at latest release's commit") | ||
| flag.BoolVar(&conf.IncludeAuthor, "include-author", conf.IncludeAuthor, "Include author of PR in message") | ||
| flag.StringVar(&conf.GitHubToken, "github-token", os.Getenv("GITHUB_TOKEN"), "Github Token. (Defaults to env GITHUB_TOKEN)") |
Owner
There was a problem hiding this comment.
I like the flag, but I'd prefer not to expose the token via the --help text (because it will print the default).
Contributor
Author
There was a problem hiding this comment.
Makes sense, changed to hide that during --help and set during actual parsing
Owner
|
Thanks for doing this. Nice improvements! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.