Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally I just wanted to upgrade the material library version but saw other dependencies are also outdated and when I upgraded them it made me upgrade Kotlin version also as it refused to compile without it. Then I saw ksp is relying to an old version of Gradle so went ahead to upgrade that as well.
There is a binary file change at
gradle/wrapper/gradle-wrapper.jarwhich made the CI to use https://github.com/gradle/wrapper-validation-action in order to validate it. You can/should check it yourself also,$ shasum -a 256 gradle/wrapper/gradle-wrapper.jar
ed2c26eba7cfb93cc2b7785d05e534f07b5b48b5e7fc941921cd098628abca58 gradle/wrapper/gradle-wrapper.jar
Which matches https://gradle.org/release-checksums/
If you feel I should separate the change it's ok to me.