Rework python-cmethods: replace the CMethods class by the new adjust function
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 3, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 98.23% 98.08% -0.15%
==========================================
Files 1 7 +6
Lines 283 261 -22
==========================================
- Hits 278 256 -22
Misses 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
riley-brady
reviewed
Jan 16, 2024
riley-brady
left a comment
There was a problem hiding this comment.
Great job with this! I just focused mainly on the apply ufunc implementation. Just a few comments here. It worked on my example data over 1-4D, and very quickly with dask.
CMethods class with the new adjust function
CMethods class with the new adjust functionCMethods class by the new adjust function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the performance of applied bias corrections, the complete CMethods class was removed. Individual techniques can't be executed directly by calling their function anymore. Also the
adjust_3dfunction was removed.Instead, a new function named
adjustwas added which acts like the oldadjust_3dfunction but can handle single and multidimensional data sets and will return the bias corrected data as xarray.Dataset. By using xarrays ufunc function instead of iterating over entries per dimension, the execution time could be reduced drastically.linear_scaling,variance_scalingand so on are now internal functions and should not be called directly, they are not part of the documentation anymore. Instead, a new section in the documentation was added - which describes the implemented methods and provides some examples.More changes:
Follow-up: Create issue for improving the DQM function (#48 (comment)).