Wallet Transactions Export: Add BIP-329 support#4799
Merged
Conversation
Member
|
Can I test it somewhere with another wallet? I believe you should also export the addresses. Me or @Kukks can add that to the PR after. Also it should be |
Kukks
suggested changes
Mar 22, 2023
Kukks
suggested changes
Mar 22, 2023
Member
|
I give up implementing address export for now. |
NicolasDorier
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the BIP 329 export format.
Sample transactions export:
{"type":"tx","ref":"9eb4b1f69dc0aad88f2530fdd124c77021c1633500e14369d0896bf75a025596","label":"microtransaction"} {"type":"tx","ref":"98ee2e20e45967eeda330b191d881584d1e02ea05e633e4cb7c48aea8980fc63","label":"test"} {"type":"tx","ref":"84ce8b198d85e715588da114b7b441833cfc4892ba9aa1f7f3cfbfdcf2ca1235","label":"Mining Income, microtransaction, test"}Currently only the transaction data is exported, but I think we can also leverage the new labeling system to export other types, like
addras well. @NicolasDorierCloses #4536.