chore(claude): vendor review subagents + fix agent definitions#991
Merged
oskarszoon merged 4 commits intoJun 1, 2026
Merged
Conversation
- Vendor 9 specialist subagents from VoltAgent/awesome-claude-code-subagents (golang-pro, code-reviewer, security-auditor, qa-expert, performance-engineer, typescript-pro, frontend-developer, security-engineer, penetration-tester), each annotated with its upstream source link. - Add missing `description` frontmatter to bitcoin-expert so it registers reliably as a selectable subagent. - Fold review-docs' parallel per-directory fan-out into document-reviewer, then remove review-docs; repoint claude-code-review.yml and rules/agents.md at document-reviewer. - List all available agents in .claude/rules/agents.md. Tooling/CI-prompt only; no code or runtime behavior changes.
Contributor
|
🤖 Claude Code Review Status: Complete No issues found. This PR properly vendors 9 specialist subagents from VoltAgent/awesome-claude-code-subagents with correct MIT licensing headers, fixes the bitcoin-expert agent registration issue, and consolidates the documentation review agents. All changes are tooling/CI-prompt only with no runtime impact. |
icellan
approved these changes
May 29, 2026
Per the MIT license of VoltAgent/awesome-claude-code-subagents, each vendored agent now carries an SPDX-License-Identifier, copyright notice, and source link (replacing the prior plain source comment).
…ents (MIT) Includes the verbatim MIT license text and copyright covering the 9 .claude/agents/ files vendored from VoltAgent/awesome-claude-code-subagents, satisfying MIT's notice-retention requirement alongside the per-file SPDX headers.
Contributor
Benchmark Comparison ReportBaseline: Current: Summary
All benchmark results (sec/op)
Threshold: >10% with p < 0.05 | Generated: 2026-05-29 19:50 UTC |
…op THIRD_PARTY_LICENSES Vendored agents carried stray Outworked-tool frontmatter (outworked-*); re-copied clean from upstream, keeping only the MIT SPDX/copyright/source header. Per-file headers suffice here; a repo-wide THIRD_PARTY_LICENSES is deferred as a separate, broader change.
|
ordishs
approved these changes
Jun 1, 2026
ordishs
left a comment
Collaborator
There was a problem hiding this comment.
Approve. Tooling/docs-only change — no Go or runtime surface touched. Verified mechanical integrity:
- No dangling
review-docsreferences; CI workflow andagents.mdboth correctly repointed atdocument-reviewer.md, which exists and is well-formed. - Frontmatter valid on all agent files;
bitcoin-expertnow has itsdescription. SPDX/copyright headers are inert YAML comments, so they don't pollute agent metadata.
Non-blocking nits for a future pass: the vendored agents hard-pin model: opus/sonnet (cost lever — four default to Opus), carry upstream "context-manager" boilerplate that references a nonexistent collaborator, and strict MIT compliance depends on the deferred NOTICES work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.claude/agents/as real files:golang-pro,code-reviewer,security-auditor,qa-expert,performance-engineer,typescript-pro,frontend-developer,security-engineer,penetration-tester.bitcoin-expert: it had nodescriptionfrontmatter, so it failed to register as a selectable subagent in stricter sessions. Added one.review-docs' parallel per-directory fan-out methodology intodocument-reviewer, then removedreview-docs. Repointed the code-review workflow (.github/workflows/claude-code-review.yml) and.claude/rules/agents.mdatdocument-reviewer..claude/rules/agents.md.Why
The repo's
.claude/agentsset was missing every language/security/perf reviewer the team relies on for PR reviews, andbitcoin-expertwas silently unavailable in some sessions (missingdescription). Consolidating the duplicate doc reviewers also removes a now-dangling reference from the code-review workflow.Licensing
The 9 vendored agents are MIT-licensed (© 2025 VoltAgent). Each carries an
SPDX-License-Identifier+ copyright + source header in its frontmatter — sufficient attribution for the vendored files. A repo-wideTHIRD_PARTY_LICENSES/NOTICES process is out of scope here and deferred as a separate, broader change.Notes