ci: remove catchpoint/workflow-telemetry-action#948
Merged
oskarszoon merged 4 commits intoMay 29, 2026
Conversation
Removes 18 invocations across 6 workflow files. Telemetry output (CPU/mem/network/disk per-job comments) was unused, and the third-party action adds an external download + runtime dependency on every CI job. Recent flakes downloading dependencies (e.g. actions/setup-go CDN errors) make leaner workflows worthwhile, and dropping an external action that runs with workflow context reduces supply-chain surface.
Contributor
|
🤖 Claude Code Review Status: Complete No issues found. This PR cleanly removes unused telemetry collection overhead from CI workflows. The changes are mechanical, consistent, and improve the security posture by eliminating a third-party action dependency. Summary:
|
Contributor
Benchmark Comparison ReportBaseline: Current: Summary
All benchmark results (sec/op)
Threshold: >10% with p < 0.05 | Generated: 2026-05-26 13:45 UTC |
|
icellan
approved these changes
May 27, 2026
ordishs
approved these changes
May 28, 2026
ordishs
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Clean, well-scoped CI maintenance — removes all 18 invocations of the unused telemetry action with no downstream references (no step id, no consumed outputs, no artifact deps). Reduces third-party action surface and shaves a small amount of CI overhead. Verified completeness against current main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 18 invocations of
catchpoint/workflow-telemetry-actionacross 6 workflow files.The action injected a CPU/memory/network/disk telemetry collector into every CI job and posted PR comments (already disabled via
comment_on_pr: "false"). Nobody is consuming that output, so it's pure overhead: an external download + step on every job, and a third-party action running in workflow context for no benefit.Action was pinned to SHA
f974e0cso supply-chain risk was low — but lowest is none.Files changed
.github/workflows/long_tests.yaml.github/workflows/nightly_tests.yaml.github/workflows/sonar-pr-analyze.yaml.github/workflows/teranode_main_tests.yaml.github/workflows/teranode_pr_smoketests.yaml.github/workflows/teranode_pr_tests.yaml108 lines deleted, 0 added.
Test plan
teranode_pr_tests,teranode_pr_smoketests,sonar-pr-analyze)actionlintclean on edited files (verified locally; only pre-existing self-hosted runner label warnings remain)