Skip to content

Optimized setTxMined LUA script#86

Merged
icellan merged 6 commits into
mainfrom
feature/optimize-settxmined
Oct 31, 2025
Merged

Optimized setTxMined LUA script#86
icellan merged 6 commits into
mainfrom
feature/optimize-settxmined

Conversation

@oskarszoon

Copy link
Copy Markdown
Contributor

No description provided.

@bsv-blockchain bsv-blockchain deleted a comment from github-actions Bot Oct 30, 2025
@bsv-blockchain bsv-blockchain deleted a comment from github-actions Bot Oct 30, 2025

@ordishs ordishs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small linting issue to fix.

Is the new Kafka code in this PR for debugging?

@icellan icellan marked this pull request as ready for review October 31, 2025 15:27
@github-actions

github-actions Bot commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

🤖 Claude Code Review

Status: Complete


Current Review:

This PR includes a Lua optimization and a new debugging tool. The changes appear well-structured.

Main Changes:

  • Lua Script Optimization (teranode.lua): Replaces list.iterator with indexed loops and optimizes conditional block removal to skip rebuilding lists when block not found
  • Kafka Connector Tool (new file): Adds CLI debugging tool to read Aerospike CDC from Kafka and filter by transaction ID
  • Minor fixes: Added kafka message key, clarified comment about size counter decrement

Observations:

  • The Lua optimization reduces unnecessary list rebuilds in setMined which should improve performance
  • The new aerospikekafkaconnector tool follows existing CLI patterns
  • Proper signal handling and graceful shutdown implemented
  • Variable filterBytes at line 83 is computed but never used (txID comparison uses string hex values instead)

No critical issues identified.

@sonarqubecloud

Copy link
Copy Markdown

@icellan icellan merged commit 7aa9b0e into main Oct 31, 2025
14 checks passed
@icellan icellan deleted the feature/optimize-settxmined branch October 31, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants