chore(deps): bump go-chaincfg to v1.5.8#849
Merged
oskarszoon merged 1 commit intoMay 12, 2026
Merged
Conversation
Brings in three new checkpoints added in v1.5.8: - mainnet: 945000 (0x00000000000000000c39d94...) - testnet: 1730000 (0x00000000000e61ef...) - teratestnet: 18000 (0x000000001740...) These speed up initial block download and harden the chain against deep reorgs by extending the hard-coded checkpoint list. Collateral changes from go-chaincfg v1.5.5 → v1.5.8: - go-wire: 1.2.1 → 1.2.3 (transitive) - go-bt/v2: 2.6.1 → 2.6.3 (transitive, pulled into Teranode go.mod) - go-sdk: 1.2.18 → 1.2.23 (transitive, pulled into Teranode go.mod) - go-chaincfg itself: Go toolchain bump from 1.24 → 1.25; no exported API surface changes TestHighestCheckpointHeight/mainnet_params updated to expect 945000 (the new highest checkpoint) instead of the previous 938000.
Contributor
|
🤖 Claude Code Review Status: Complete Current Review: This is a clean dependency bump with appropriate test updates. The PR correctly updates Key observations:
Checkpoint usage verified in:
No issues found. |
icellan
approved these changes
May 12, 2026
|
Contributor
Benchmark Comparison ReportBaseline: Current: Summary
All benchmark results (sec/op)
Threshold: >10% with p < 0.05 | Generated: 2026-05-12 12:21 UTC |
ordishs
approved these changes
May 12, 2026
ordishs
left a comment
Collaborator
There was a problem hiding this comment.
Clean dependency bump. Test fixture correctly updated to match new mainnet checkpoint at 945000. Verified no hardcoded checkpoint heights elsewhere in the codebase — checkpoints flow through ChainCfgParams.Checkpoints as expected. All CI green, SonarQube clean, no benchmark regressions. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
github.com/bsv-blockchain/go-chaincfgfrom v1.5.5 to v1.5.8.What's in v1.5.8
Checkpoints (the main change):
0x00000000000000000c39d94e19d6a55cfb0454918df1814fbcd919353a6e1f82)0x00000000000e61efa6a236cd94662eefc814a24affb9f24b002ebc4b018e4256)0x00000000174095c3c94343b28d29f45010b44bf221e22df5cea6e0ce547a10b5)These extend the hard-coded checkpoint list to speed up IBD and harden against deep reorgs.
Collateral dependency bumps in go-chaincfg (no API surface changes):
go-wire: 1.2.1 → 1.2.3go-bt/v2: 2.6.1 → 2.6.3go-sdk: 1.2.18 → 1.2.23golang.org/x/crypto: 0.48.0 → 0.50.0No exported symbols were added, removed, or renamed. Checkpoints flow through
ChainCfgParams.Checkpointsintocatchup.go; there are no hardcoded duplicate checkpoint heights in Teranode.Test plan
go build ./...— cleango test ./settings/... ./services/blockchain/... ./services/blockvalidation/...— 1550 tests, all passTestHighestCheckpointHeight/mainnet_paramsupdated to expect 945000 (new highest checkpoint)ChainCfgParams.Checkpoints; no hardcoded duplicates in Teranode