Claude finished @oskarszoon's task —— View job

Review Complete

• Read PR diff and understand changes
• Review the fix for correctness
• Check for consistency with related code
• Post review feedback

Analysis

This PR correctly adds the missing TxCount and SubtreeCount fields to the notificationMsg struct instantiation in handleNodeStatusTopic() at services/p2p/Server.go:930-931.

The Fix:

• Local node status messages (created by getNodeStatusMessage() at line 1229-1230) already include these fields
• Remote peer messages (handled by handleNodeStatusTopic() at line 881) were missing the field mapping
• The fix properly maps nodeStatusMessage.TxCount and nodeStatusMessage.SubtreeCount to the notification message

Verification:

• NodeStatusMessage struct (line 864-865) defines both fields with omitempty tags
• notificationMsg struct (HandleWebsocket.go:32,41) has matching TxCount and SubtreeCount fields
• Field ordering matches the struct definition (between BestHeight and FSMState)
• Both fields use the same types: uint64 for TxCount, uint32 for SubtreeCount

Assessment:
LGTM - This is a straightforward bug fix that ensures parity between local and remote node status message handling. The change is minimal, correct, and maintains consistency with the existing codebase structure.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud