Merged
Conversation
brycx
requested changes
May 13, 2020
Owner
brycx
left a comment
There was a problem hiding this comment.
This seems like a worthwhile change, I hadn't thought about this before.
Perhaps load_config should also return this instead, since it's used directly in main.rs? Also, we probably want to propagate all the current unwrap()s with ? in the functions returning a Result. Though this could also be implemented in a different PR.
clippy has some complaints that would be nice to have fixed before merging this.
…`; updated comment in `main.rs`
Contributor
Author
|
Made the requested updates. Let me know your thoughts. :) |
brycx
approved these changes
Aug 8, 2020
Owner
|
CI fails some tests, which it has done before. All tests are green locally however. LGTM. |
Owner
|
Thanks @mdtro! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a simple change the function signatures I implemented a few weeks ago. Instead of passing
io::Errorin the Result type -- I should be wrapping the Error trait in a Box to better handle all possibilities.