Fix display scaling (#24) + Open folder + light-theme gallery#28
Merged
Conversation
Display scaling was fully broken: the frontend sent uhd_4k/fhd_1080p but the Rust enum's snake_case serde produced uhd4k/fhd1080p, so every click failed with "unknown variant". Added explicit serde renames. Corrected the Shield 4K preset to 3839x2160 @ density 640 (was 3840x2160 @ 540) per issue #24 — Shield TV rejects a 3840 width and 540 broke Disney+/HBO menus. Applied to both the v2 app and the v1 PowerShell script. Open folder on the Snapshots page used an open_path call the app wasn't permitted to make; switched to reveal_item_in_dir (in the default permission set, no path scope) and made snapshot_dir_path create the folder up front so it works before the first snapshot. Screenshot pipeline now captures light frames too and builds gallery-light.gif; both READMEs show a light-theme walkthrough and the release refresh-screenshots job commits both GIFs. Closes #24
# Conflicts: # v2/screenshots/gallery.gif
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes from Reddit / issue #24, plus light-theme screenshots.
uhd_4k/fhd_1080p, the Rust enum's snake_case serde produceduhd4k/fhd1080p, so every click failed with "unknown variant". Fixed with explicit serde renames.3839×2160 @ density 640(was3840×2160 @ 540). Shield rejects a 3840 width; 540 broke Disney+/HBO menus. Fixed in both the v2 app and the v1 PowerShell script.open_paththe app wasn't permitted to make → switched toreveal_item_in_dir(already permitted, no path scope) and the folder is created up front.Closes #24