Light theme + Light/Dark/Auto toggle (fixes #26)#27
Merged
Conversation
Light appearance previously left cards and text in dark-mode colors over a light page, making text nearly unreadable on Linux/macOS. The UI is now fully theme-aware: every hardcoded color became a semantic CSS variable with both a dark value (unchanged from before) and a light value tuned for contrast. A header toggle (Light / Dark / Auto) drives a data-theme attribute and persists to localStorage; Auto follows the OS via prefers-color-scheme. An inline app.html script applies the saved choice before first paint to avoid a flash. Closes #26
Several danger buttons (Emergency Recovery, recommended.danger, the small-action danger hovers) used a literal white text color on top of --danger-surface. In dark mode that's white-on-dark-red (fine), but in light mode --danger-surface is a light pink, so the white text was nearly invisible. Added a --danger-surface-text token (white in dark — unchanged — dark red in light) and used it for those buttons. Verified readable in both modes via the demo harness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Light appearance left the cards and text in dark-mode colors over a light page, making text nearly unreadable on Linux/macOS (#26).
The UI is now fully theme-aware — every hardcoded color became a semantic CSS variable with a dark value (unchanged) and a contrast-tuned light value. A header Light / Dark / Auto toggle overrides the system appearance and persists; Auto follows the OS. Verified both themes and the override render correctly via the demo screenshot harness.
Closes #26