Merged
Conversation
Contributor
Author
|
Bumping this. I believe this is a good change and not hard to support upstream. |
Contributor
Author
|
Also as an FYI this will now bump minimum deployment target to iOS 9 for Xcode 12 support |
bryanjclark
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128
This PR adds support for iOS app groups. This enables the tweaks to be accessed via iOS extensions that might utilize internal variables common to the main app (think API domain names and the like). I implemented this using a default, optional parameter on the main initializer which is a non-breaking API change for implementing developers. All other changes occurred on internal classes.
I already pulled my branch into my side project app and confirmed it to work. Since this depends upon several OS security mechanisms to work correctly (FileManager's containerURL() function, and the general OS sandbox security mechanisms), I couldn't figure out a way to appropriately unit test this new functionality. If you have thoughts around that I'd be happy to add them.