fix: nix package dependencies#7
Merged
brumhard merged 1 commit intobrumhard:mainfrom Sep 9, 2024
ajgon:feat/fix-deps
Merged
Conversation
|
This works great for me on NixOS 24.05. |
budimanjojo
reviewed
Sep 9, 2024
Owner
|
LGTM. I appreciate it guys 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
hm-modules.nixfiles won't work on raw NixOS filesystems, becausegitis missing during build phase - andkrewdepends on it (and for some reason, default package doesn't provide it). This PR adds it, and ensures it will be available during activation.