Skip to content

✨ Add hm-module#5

Merged
brumhard merged 9 commits intobrumhard:mainfrom
RAPSNX:hm-module
Jun 10, 2024
Merged

✨ Add hm-module#5
brumhard merged 9 commits intobrumhard:mainfrom
RAPSNX:hm-module

Conversation

@RAPSNX
Copy link
Copy Markdown
Contributor

@RAPSNX RAPSNX commented Jun 5, 2024

Adds a hm-module to configure krewfile.

Basic capabilities:

  • install krewfile & krew
  • configure which package of krew to install
  • list of plugins to install
  • configure PATH for kubectl to find plugins (need to start new terminal session)

@brumhard brumhard linked an issue Jun 5, 2024 that may be closed by this pull request
@brumhard
Copy link
Copy Markdown
Owner

brumhard commented Jun 5, 2024

What a great contribution 🫶🏼 Could you add some docs for how to use it? Of course, if you have some link to existing docs, that'd be even better 🙂

Copy link
Copy Markdown
Owner

@brumhard brumhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback

@RAPSNX RAPSNX requested a review from brumhard June 5, 2024 15:38
@RAPSNX RAPSNX mentioned this pull request Jun 5, 2024
@RAPSNX RAPSNX changed the title Add hm-module ✨ Add hm-module Jun 5, 2024
Copy link
Copy Markdown
Owner

@brumhard brumhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, I'll test it out in my own config 👍🏻

@brumhard
Copy link
Copy Markdown
Owner

brumhard commented Jun 6, 2024

Just tried integrating it into my own setup. With the docs you provided it works like a charm 🕺🏻

Co-authored-by: Tobias Brumhard <code@brumhard.com>
@RAPSNX RAPSNX requested a review from brumhard June 8, 2024 23:55
Copy link
Copy Markdown
Owner

@brumhard brumhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the work you put into it 🫶

@brumhard brumhard merged commit ce17d82 into brumhard:main Jun 10, 2024
@RAPSNX RAPSNX deleted the hm-module branch June 10, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NixOS / Home-manager module

2 participants