Merged
Conversation
Version 1.4.3 through 1.4.6 had an issue where the MD5 had to be different, and they always were because we were originally creating the md5sum of the plugins.zip, not the XML. Now we've corrected it, we need a way for the hash to remain "wrong" for 1.4.3 through 1.4.6, but correct for 1.4.8 onwards. Changing the URL for the MD5 is how we're doing that, so plugins.md5.txt still exists, but it contains an old hash that will never be correct. plugins2.md5.txt contains the correct hash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1.4.3 through 1.4.6 had an issue where the MD5 had to be
different, and they always were because we were originally creating the
md5sum of the plugins.zip, not the XML. Now we've corrected it,
we need a way for the hash to remain "wrong" for
1.4.3 through 1.4.6, but correct for 1.4.8 onwards.
Changing the URL for the MD5 is how we're doing that, so plugins.md5.txt
still exists, but it contains an old hash that will never be correct.
plugins2.md5.txt contains the correct hash