text-decoration : data from MDN#104
Merged
ai merged 3 commits intobrowserslist:mainfrom Sep 12, 2022
romainmenke:add-text-decoration-from-mdn--practical-peacock-f2a3435f83
Merged
text-decoration : data from MDN#104ai merged 3 commits intobrowserslist:mainfrom romainmenke:add-text-decoration-from-mdn--practical-peacock-f2a3435f83
ai merged 3 commits intobrowserslist:mainfrom
romainmenke:add-text-decoration-from-mdn--practical-peacock-f2a3435f83
Conversation
ai
reviewed
Sep 12, 2022
romainmenke
commented
Sep 12, 2022
copy-mdn.js
Outdated
| 'text-decoration shorthand property' | ||
| ) | ||
| writeFileSync( | ||
| './node_modules/caniuse-db/features-json/css-text-decoration_shorthand.json', |
Contributor
Author
There was a problem hiding this comment.
@ai Is the underscore ok here?
I followed the convention from caniuse (mdn-css_properties_text-decoration_shorthand)
Member
There was a problem hiding this comment.
I used just mdn- prefix. But maybe it is a good idea to copy all. afe96e5
What do you think?
Contributor
Author
There was a problem hiding this comment.
I've renamed to mdn-text-decoration-shorthand.json I think this fits better with mdn-css-unicode-bidi-isolate-override.json
Member
|
(You will also need to rebase PR since I added my data too) |
Member
|
Now let’s wait next |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds data for :
text-decoration(as shorthand)text-decoration-colortext-decoration-linetext-decoration-styleThis data is needed to correctly resolve postcss/autoprefixer#1473