Skip to content

Conversation

@rylancates
Copy link
Contributor

As you can see:

  • I don't know the details for Darwin as I don't have a Mac
  • I don't know what needs to happen with Edge to get system-wide install working
  • I don't know what the policies make steps are for or how to test

Makefile Outdated
hosts-edge:
# THIS DOESN'T WORK
@case $(OS) in \
Linux) mkdir -p "/opt/microsoft/msedge/native-messaging-hosts/"; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of the comment, let's just have Linux) block commented out too, so that the make goal exists, but using it would result in getting an error message, hopefully encouraging community to contribute 😜

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, sounds like a plan. I've pushed an update with this change

| `make hosts-firefox-user` | Configure browserpass for Firefox browser, for the current user only |
| `make hosts-librewolf-user`| Configure browserpass for Librewolf browser, for the current user only |
| `make hosts-chrome-user` | Configure browserpass for Google Chrome or Opera browsers, for the current user only |
| `make hosts-edge-user` | Configure browserpass for Microsoft Edge browser, for the current user only |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line with the suggestion above, let's add the hosts-edge to the README as well 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change pushed!

@rylancates
Copy link
Contributor Author

rylancates commented May 19, 2022

I've updated the PR to include the changes you've asked for along with stubs for the policy steps commented out so that a nice failure is printed for those steps as well. I've updated the readme for both hosts and policies in kind.

@max-baz
Copy link
Member

max-baz commented May 19, 2022

Awesome, thanks for your contribution!

@max-baz max-baz merged commit 181ad38 into browserpass:master May 19, 2022
@rylancates
Copy link
Contributor Author

Thanks for being a kind and helpful maintainer 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants