-
Notifications
You must be signed in to change notification settings - Fork 57
feat: add edge user support #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Makefile
Outdated
| hosts-edge: | ||
| # THIS DOESN'T WORK | ||
| @case $(OS) in \ | ||
| Linux) mkdir -p "/opt/microsoft/msedge/native-messaging-hosts/"; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of the comment, let's just have Linux) block commented out too, so that the make goal exists, but using it would result in getting an error message, hopefully encouraging community to contribute 😜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, sounds like a plan. I've pushed an update with this change
| | `make hosts-firefox-user` | Configure browserpass for Firefox browser, for the current user only | | ||
| | `make hosts-librewolf-user`| Configure browserpass for Librewolf browser, for the current user only | | ||
| | `make hosts-chrome-user` | Configure browserpass for Google Chrome or Opera browsers, for the current user only | | ||
| | `make hosts-edge-user` | Configure browserpass for Microsoft Edge browser, for the current user only | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line with the suggestion above, let's add the hosts-edge to the README as well 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change pushed!
|
I've updated the PR to include the changes you've asked for along with stubs for the policy steps commented out so that a nice failure is printed for those steps as well. I've updated the readme for both hosts and policies in kind. |
|
Awesome, thanks for your contribution! |
|
Thanks for being a kind and helpful maintainer 😎 |
As you can see: