Passing tests on Windows and Node 10 #1819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e09df06 to
f405cf2
Compare
- Use path.join in more places in tests so they can run on windows - Fix noParse check on windows - Fix regex in multi_entry test for windows paths - Skip symlink tests on windows - Fix ignore check on windows - Fix paths in noparse and ignore tests on windows.
Replace backslashes with forward slashes when adding relative paths for external references.
Not sure why this is failing, and can't test it well, so skipping for now with a TODO comment
This was referenced Jun 1, 2021
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path.joininstead of string concat in some places in tests