fix: preserve keep-alive browser event bus#5031
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
1e82e22 to
856e3f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agent.close()from stopping the browser event bus whenkeep_alive=TrueFixes #4374.
Test plan
python -m py_compile browser_use/agent/service.py tests/ci/test_agent_close.pypython -m pytest tests/ci/test_agent_close.py -qpython -m ruff check browser_use/agent/service.py tests/ci/test_agent_close.py --no-fixgit diff --checkSummary by cubic
Keeps the browser event bus alive during
Agent.close()when keep_alive=True, preserving the event queue and idle callback so CDP WebSocket handlers persist into the next run. Adds tests for both keep-alive and non-keep-alive close behavior.Written for commit 856e3f2. Summary will update on new commits.