fix: warn on boolean input text indices#4942
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Author
|
Rebased on current Validated: uv run pytest tests\ci\infrastructure\test_tool_views.py -q --basetemp .tmp\pytest-4942
uv run ruff check browser_use\tools\views.py tests\ci\infrastructure\test_tool_views.py
python -m py_compile browser_use\tools\views.py tests\ci\infrastructure\test_tool_views.py
git diff --check origin/main...HEADAll passed after the rebase. |
2df57ac to
1f3a03b
Compare
Author
|
Rebased this branch onto the latest upstream Validated locally:
|
1f3a03b to
bb787f6
Compare
Author
|
Rebased this branch onto current Focused validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input_text.indexis a JSON boolean before pydantic coerces it to an integerFixes #4796
To verify
Summary by cubic
Warn when
InputTextAction.indexis a JSON boolean using apydanticfield_validator(mode='before'), logging a warning while preserving int coercion for compatibility. Adds a regression test that checks the warning and thatTrue/Falsecoerce to 1/0; fixes #4796.Written for commit bb787f6. Summary will update on new commits.