fix(openai): report empty structured output#4833
Open
Lubrsy706 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelProviderErrorwith response diagnostics such asresponse_idandfinish_reasonNone, empty string, and whitespace-only contentWhy
When OpenAI chat completions return an empty structured-output message, browser-use currently surfaces a low-level Pydantic EOF error. That makes agent failures much harder to diagnose after long runs. This keeps the error at the provider boundary and preserves useful completion metadata.
Fixes #4786.
Tests
uv run pytest tests/ci/models/test_llm_openai_structured_output.pyuv run ruff format --check browser_use/llm/openai/chat.py tests/ci/models/test_llm_openai_structured_output.pyuv run ruff check browser_use/llm/openai/chat.py tests/ci/models/test_llm_openai_structured_output.pygit diff --checkSummary by cubic
Detects and reports empty OpenAI structured-output before JSON parsing, returning a clear provider error with diagnostics instead of a
pydanticEOF. Adds tests forNone, empty, and whitespace-only messages.None/empty/whitespacemessage.contentand raisesModelProviderError(502) withresponse_id,finish_reason, andbase_urlwhen available.pydanticEOF errors from leaking past the provider boundary.Written for commit f1f456e. Summary will update on new commits.