Reject boolean input_text indexes#4815
Open
FU-max-boop wants to merge 1 commit into
Open
Conversation
|
|
10f6f56 to
f901236
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4796.
Summary
InputTextAction.indexto a strict integer so booleans are not coerced into element indexes.true/falseindexes while preserving normal integer indexes.Validation
python3 -m py_compile browser_use/tools/views.py tests/ci/test_action_validation.pygit diff --check.venv-test/bin/python -m pytest tests/ci/test_action_validation.py -qSummary by cubic
Reject boolean indexes in
InputTextActionby switchingindextoStrictIntsoTrue/Falseare not coerced to 1/0. Add tests that fail on boolean indexes and pass for valid integer indexes.Written for commit f901236. Summary will update on new commits.
Review in cubic