Skip to content

php 8.2 support#515

Merged
asgrim merged 1 commit intobrowscap:7.2.xfrom
vemaeg:feature/php-8.2-support
Dec 30, 2022
Merged

php 8.2 support#515
asgrim merged 1 commit intobrowscap:7.2.xfrom
vemaeg:feature/php-8.2-support

Conversation

@thirsch
Copy link
Copy Markdown
Contributor

@thirsch thirsch commented Dec 29, 2022 •
edited
Loading

local tests are running fine and ignoring the dependency, it's running on a project fine as well. Fixes #507

@mimmi20 mimmi20 requested a review from asgrim December 29, 2022 11:50
@asgrim asgrim self-assigned this Dec 29, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 29, 2022 •
edited
Loading

Codecov Report

Base: 36.26% // Head: 36.26% // No change to project coverage 👍

Coverage data is based on head (577bfe9) compared to base (8bd54ea).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##              7.2.x     #515   +/-   ##
=========================================
  Coverage     36.26%   36.26%           
  Complexity      286      286           
=========================================
  Files            27       27           
  Lines          1183     1183           
=========================================
  Hits            429      429           
  Misses          754      754
Flag Coverage Δ
phpunit 36.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@asgrim
Copy link
Copy Markdown
Member

asgrim commented Dec 29, 2022

@mimmi20 Hmm, we have failing tests here;

@mimmi20 mimmi20 self-requested a review December 29, 2022 16:23
mimmi20
mimmi20 requested changes Dec 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mimmi20 mimmi20 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the PR to the current HEAD and then run composer update --prefer-lowest. This may get the failing test run.

@thirsch thirsch force-pushed the feature/php-8.2-support branch from 57b5fbe to 577bfe9 Compare December 29, 2022 17:26
@mimmi20
Copy link
Copy Markdown
Member

mimmi20 commented Dec 29, 2022

@mimmi20 Hmm, we have failing tests here; ...

@asgrim this is solved, please review again

asgrim
asgrim approved these changes Dec 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@asgrim asgrim merged commit a033f93 into browscap:7.2.x Dec 30, 2022
@asgrim asgrim added this to the 7.2.0 milestone Dec 30, 2022
@asgrim
Copy link
Copy Markdown
Member

asgrim commented Dec 30, 2022

@thirsch and @mimmi20 thank you both! browscap/browscap-php:7.2.0 is now released with PHP 8.2 support 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asgrim asgrim asgrim approved these changes

@mimmi20 mimmi20 mimmi20 approved these changes

Assignees

@asgrim asgrim

Labels

enhancement

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

Can't install browscap-php with php 8.2

4 participants

@thirsch @codecov-commenter @asgrim @mimmi20