Skip to content

Added support for PHP 8.1, updated several dependencies#406

Merged
asgrim merged 5 commits into6.0.xfrom
updates
Dec 11, 2021
Merged

Added support for PHP 8.1, updated several dependencies#406
asgrim merged 5 commits into6.0.xfrom
updates

Conversation

@mimmi20
Copy link
Copy Markdown
Member

@mimmi20 mimmi20 commented Dec 3, 2021 •
edited by asgrim
Loading

Fixes #334

asgrim
asgrim reviewed Dec 3, 2021
View reviewed changes
asgrim
asgrim reviewed Dec 3, 2021
View reviewed changes
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 3, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (6.0.x@c4c907e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             6.0.x     #406   +/-   ##
========================================
  Coverage         ?   40.94%           
  Complexity       ?      286           
========================================
  Files            ?       27           
  Lines            ?     1033           
  Branches         ?        0           
========================================
  Hits             ?      423           
  Misses           ?      610           
  Partials         ?        0
Flag Coverage Δ
7.4 40.94% <0.00%> (?)
php-7.4 40.94% <0.00%> (?)
phpunit 40.94% <0.00%> (?)
ubuntu-20.04 40.94% <0.00%> (?)
xdebug 40.94% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4c907e...d66dd89. Read the comment docs.

@asgrim asgrim added this to the 6.0.0 milestone Dec 3, 2021
asgrim
asgrim reviewed Dec 3, 2021
View reviewed changes
@asgrim asgrim removed the BC break label Dec 8, 2021
@asgrim asgrim modified the milestones: 6.0.0, 5.1.0 Dec 8, 2021
asgrim
asgrim reviewed Dec 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking good here 👍 Could probably do with squashing a few of the commits though to show clearer commit messages 😅

@mimmi20 mimmi20 marked this pull request as ready for review December 8, 2021 17:34
@mimmi20 mimmi20 added the dependencies Pull requests that update a dependency file label Dec 8, 2021
@mimmi20 mimmi20 mentioned this pull request Dec 8, 2021
Merged
@asgrim asgrim changed the title update dependencies Added support for PHP 8.1, updated several dependencies Dec 10, 2021
@asgrim asgrim modified the milestones: 5.1.0, 6.0.0 Dec 10, 2021
@asgrim asgrim self-assigned this Dec 10, 2021
@asgrim asgrim changed the base branch from 5.1.x to 6.0.x December 10, 2021 08:28
mimmi20
mimmi20 commented Dec 10, 2021
View reviewed changes
mimmi20 and others added 3 commits December 10, 2021 08:46
@mimmi20 @asgrim
Added support for PHP 8.1 and updated several dependencies
583b761 
parent c4c907e
author Thomas Müller <thomas.mueller@jungdms.de> 1638516208 +0100
committer Thomas Müller <thomas.mueller@jungdms.de> 1638986305 +0100

update dependencies
@asgrim
Roave/BCC checker now requires PHP 8+
7317283
@asgrim
Remove composer outdated check
475fd9f 
It does not make sense to have this check on a library, as the "lowest" dependencies
will ALWAYS be outdated.
@asgrim
Copy link
Copy Markdown
Member

asgrim commented Dec 11, 2021

BC breaks are expected here, and documented now in README.md. Merging into 6.0.x.

@asgrim asgrim merged commit 1415d50 into 6.0.x Dec 11, 2021
@asgrim asgrim deleted the updates branch December 11, 2021 16:07
@asgrim
Copy link
Copy Markdown
Member

asgrim commented Dec 11, 2021 •
edited
Loading

@mimmi20 thank you for working on this, it is now merged and released for 6.0.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asgrim asgrim asgrim left review comments

Assignees

@asgrim asgrim

Labels

BC break dependencies Pull requests that update a dependency file enhancement

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Use doctrine/coding-standard for applying CS

3 participants

@mimmi20 @codecov-commenter @asgrim