-
Notifications
You must be signed in to change notification settings - Fork 136
Description
Repro is with Zui commit 4b851d8.
The changes in #2972 generally improved the presentation of Zed query parse errors. For instance, to establish the "before" state, at commit f985e66, here's how the error looked when typing an incomplete query like from (.
Repro-before.mp4
This kind of awful looking error dump is now replaced with the more succinct and helpful error messages such as shown here. However, for this specific from ( example, here's what we see at commit 4b851d8 that has the changes from #2972.
Repro-after.mp4
A paste of that error:
error parsing Zed at line 2, column 3:
| { i: count(), v: this}
= ^ ===
This is a reference to some of the behind-the-scenes additions we make to the user's query in order to gather metadata about how many values were in the query result, paginate results, etc.
Since this part of the query was not typed by the user, it seems likely to cause confusion. I don't know if the fix for this would actually have to be in the Zed parser, but I'm starting by opening up in Zui since triggering the problem is unique to how it augments the user's query.