Conversation
This commit changes the BSUP version number from 0 to 1 and expands the version number bits from 0 to 7. There is currently no backward compatibility with version 0 and instead an error will be reported when trying to read old BSUP files.
352183f to
df148ba
Compare
nwt
approved these changes
Feb 27, 2026
sio/bsupio/parser.go
Outdated
Comment on lines
+24
to
+25
| const BSUP_VERSION = 1 | ||
| const BSUP_MAGIC = "BSUP" |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| const BSUP_VERSION = 1 | |
| const BSUP_MAGIC = "BSUP" | |
| const BSUPVersion = 1 | |
| const BSUPMagic = "BSUP" |
sio/bsupio/parser.go
Outdated
| version = int(code & 0x7f) | ||
| } | ||
| if version != BSUP_VERSION { | ||
| return fmt.Errorf("BSUP version mismatch: expected %d found %d", BSUP_VERSION, version) |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| return fmt.Errorf("BSUP version mismatch: expected %d found %d", BSUP_VERSION, version) | |
| return fmt.Errorf("BSUP version mismatch: expected %d, found %d", BSUP_VERSION, version) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the BSUP version number from 0 to 1 and expands the version number bits from 0 to 7. There is currently no backward compatibility with version 0 and instead an error will be reported when trying to read old BSUP files.