Conversation
The type fusion algorithm can create unions containing multiple complex types of the same kind (e.g, multiple array types) and multiple types with the same type ID (because of named types). Change the algorithm so that unions in fused types never contain unions, have at most one instance of each kind of non-union complex type, and have at most one type with a given type ID.
mccanne
approved these changes
Feb 20, 2026
mattnibs
reviewed
Feb 20, 2026
runtime/sam/expr/agg/fuser.go
Outdated
| } | ||
|
|
||
| func (f *Fuser) fuse(a, b super.Type) super.Type { | ||
| func (f *Fuser) fuse(a, b super.Type) (x super.Type) { |
Collaborator
There was a problem hiding this comment.
Is this variable return type being used (didn't look like it to me).
Member
Author
There was a problem hiding this comment.
Thanks for catching that. Just debug garbage I forgot to remove.
mattnibs
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type fusion algorithm can create unions containing multiple complex types of the same kind (e.g, multiple array types) and multiple types with the same type ID (because of named types). Change the algorithm so that unions in fused types never contain unions, have at most one instance of each kind of non-union complex type, and have at most one type with a given type ID.
Fixes #6650