Skip to content

compiler/semantic: auto-detect Parquet files in translator.fileType#6341

Merged
nwt merged 3 commits intomainfrom
compiler-semantic-auto-detect-parquet
Nov 4, 2025
Merged

compiler/semantic: auto-detect Parquet files in translator.fileType#6341
nwt merged 3 commits intomainfrom
compiler-semantic-auto-detect-parquet

Conversation

@nwt
Copy link
Member

@nwt nwt commented Nov 4, 2025

This provides access to a Parquet file's super.Type even if its format is unspecified and its path in the query lacks a ".parquet" suffix.

Depends on #6340.

Partially fixes #5983

nwt added 2 commits November 4, 2025 12:26
Exposing os.Stdin.Close in #6338 was a mistake because opening
stdio:stdin with pkg/storage, closing it, and opening it again now
returns a reader on which reads always fail with "read /dev/stdin: file
already closed".  Hide os.Stdin.Close again to prevent that error.
This provides access to a Parquet file's super.Type even if its format
is unspecified and its path in the query lacks a ".parquet" suffix.
@nwt nwt requested a review from a team November 4, 2025 20:17
Comment on lines +8 to +9
from ( from a )
~
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@nwt
Copy link
Member Author

nwt commented Nov 4, 2025

@mattnibs: This depends on #6340 so please have a look at that too.

Base automatically changed from pkg-storage-stdin-close to main November 4, 2025 21:14
@nwt nwt merged commit 6f83f8d into main Nov 4, 2025
3 checks passed
@nwt nwt deleted the compiler-semantic-auto-detect-parquet branch November 4, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL: "ambiguous column reference" in attempted ORDER BY and/or WHERE with JOIN

2 participants