[CMS PR 36492] Fix wrong exception type and add back alert#155
Merged
brianteeman merged 2 commits intobrianteeman:sql_update_fail_logfrom Jan 8, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla#36492 .
Summary of Changes
Testing Instructions
Add a new update SQL script with a version newer than the database schema version and which contains an SQL statement which causes an SQL error, e.g. an UPDATE statement for a not existing table, to the update package for PR joomla#36492 and update a 4.0.x to that package.
Actual result BEFORE applying this Pull Request
In backend no warning alert but an unhandled exception:
The log file does not contain the new logs added by PR joomla#36492 .
When I fix the wrong exception type in the update package but don't add back the warning alert, I get:
Expected result AFTER applying this Pull Request
In backend warning alert instead of unhandled exception:
The log file contains the new logs added by PR joomla#36492 .
The misleading green success message will be handled by Nicholas' PR for 4.1-dev.
Documentation Changes Required
None.