Implement ECDSA nonce hardening to protect against bad PRNG.#662
Merged
Conversation
Owner
Author
|
This is a work in progress. It would be great to get some feedback on this. I actually don't like this nonce derivation scheme much, but we have a bit of analysis paralysis in coming up with a better one, so I'm going with this as an approximation of "Make it work like we'd more-or-less transliterated the BoringSSL code to Rust two years ago." @ctz Could you check this out and see if it makes sense to you? |
706dee7 to
27fd856
Compare
Contributor
|
I'll write out what I see to check understanding. With:
Precompute:
Per-signature:
If that's accurate it looks good to me. |
27fd856 to
b35a460
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.