Make less-safe work on espidf#1944
Conversation
|
I think we should change this to have its own feature, |
7985a2a to
3faa13d
Compare
I've updated the PR with your corrections |
3faa13d to
f9840d6
Compare
|
Great, thanks! How can I install the tools needed to cross-compile for this target so I can test that this at least builds? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
==========================================
- Coverage 96.32% 96.30% -0.03%
==========================================
Files 137 135 -2
Lines 20704 20663 -41
Branches 226 226
==========================================
- Hits 19943 19899 -44
- Misses 728 730 +2
- Partials 33 34 +1 ☔ View full report in Codecov by Sentry. |
src/lib.rs
Outdated
| //! RDRAND on x86 | ||
| //! </a> for additional details. | ||
| //! <tr><td><code>less-safe-getrandom-espidf</code> | ||
| //! <td>Treat getrandom as a secure random number generator (see |
There was a problem hiding this comment.
The rustfmt job is complaining about this line (trailing whitespace?).
briansmith
left a comment
There was a problem hiding this comment.
Thanks for doing this. This LGTM as soon as the CI passes. See the comment above about rustfmt. I would also appreciate your help in getting this target building (mk/cargo.sh test --norun, at least) in GitHub Actions, if you can.
|
@coder0xff Could you please rebase this, |
|
I'll make some time this weekend. Thanks for your patience!
…On Wed, Feb 28, 2024, 7:30 PM Brian Smith ***@***.***> wrote:
@coder0xff <https://github.com/coder0xff> Could you please rebase this, cargo
fmt to fix the CI error, and then squash the commits into one? Then I can
merge this. Thanks!
—
Reply to this email directly, view it on GitHub
<#1944 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARIHPM4JZLSPB7L4XNJG2DYV7Y4LAVCNFSM6AAAAABDD3KPFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZQGMZTCOJXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
f9840d6 to
21f5978
Compare
Rebased and formatted. Does GitHub have an option to squash on merge? I couldn't find it.
I used the guide at https://docs.esp-rs.org/book/installation/riscv-and-xtensa.html
I don't have any experience with GitHub actions. I do have a simple test project that I've been using to build for the esp32s3 target. Directory StructureContents of: build.rsContents of: .cargo/config.tomlContents of: Cargo.tomlContents of: .gitignoreContents of: rust-toolchain.tomlContents of: sdkconfig.defaultsContents of: src/main.rs |
|
@briansmith Does everything look good? |
|
Hi. Would you please trigger the workflows? |
The espidf platforms don't have an (always working) hardware RNG. #1787 plans to work around this by implementing a software CSPRNG to support such platforms. In the meantime, however, this PR enables the "less-safe-getrandom-custom-or-rdrand" feature to be used with espidf.