EC: Avoid Montgomery encoding in point arithmetic test data files.#1770
Merged
briansmith merged 2 commits intomainfrom Oct 26, 2023
Merged
EC: Avoid Montgomery encoding in point arithmetic test data files.#1770briansmith merged 2 commits intomainfrom
briansmith merged 2 commits intomainfrom
Conversation
…test vectors. `git cherry-pick 50418af`. Bring in the test vector generator unmodified.
Add a new scalar base point multiplication test case generator that where the points are *not* Montgomery-encoded. This way we don't need to generate different test data files when the Montgomery encoding for a curve isn't the same for 32-bit and 64-bit targets (P-521). This version of the generator produces the test cases for all the scalars that the current P-256 and P-384 tests generate, in the same format; the only exception is that the point is not Montgomery-encoded.
Owner
Author
|
Remaining work:
|
Codecov Report
@@ Coverage Diff @@
## main #1770 +/- ##
==========================================
+ Coverage 95.90% 96.02% +0.12%
==========================================
Files 132 138 +6
Lines 15102 20788 +5686
Branches 169 226 +57
==========================================
+ Hits 14483 19962 +5479
- Misses 598 790 +192
- Partials 21 36 +15 see 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Owner
Author
|
I'm going to merge the test case generator as-is in the interest of helping others contribute towards solving the bigger problem. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new scalar base point multiplication test case generator that where the points are not Montgomery-encoded. This way we don't need to generate different test data files when the Montgomery encoding for a curve isn't the same for 32-bit and 64-bit targets (P-521).
This version of the generator produces the test cases for all the scalars that the current P-256 and P-384 tests generate, in the same format; the only exception is that the point is not Montgomery-encoded.