FIX: mimic django rest framework default behaviour on None#9
Merged
brianjbuck merged 1 commit intobrianjbuck:masterfrom May 6, 2021
Merged
FIX: mimic django rest framework default behaviour on None#9brianjbuck merged 1 commit intobrianjbuck:masterfrom
brianjbuck merged 1 commit intobrianjbuck:masterfrom
Conversation
brianjbuck
approved these changes
May 6, 2021
Owner
brianjbuck
left a comment
There was a problem hiding this comment.
Thanks for the fix @jsmolina!
|
Thank you! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request fixes: #8
Empty reply (like http 204 status code) caused wrong behaviour, generating issues with some strict proxies.
It serialized None as 'null', causing header Content-Length to equal 4, but at the same time returning an empty body at django level.