Update TestRestart - CrossOS Passing & More Consistent#125
Merged
briandowns merged 2 commits intobriandowns:masterfrom Dec 6, 2021
Merged
Update TestRestart - CrossOS Passing & More Consistent#125briandowns merged 2 commits intobriandowns:masterfrom
briandowns merged 2 commits intobriandowns:masterfrom
Conversation
Owner
|
Is this test now running more consistently? |
Contributor
Author
|
Yep! I've tested it on my windows machine with -race and -count=30 across cmd, powershell, and wsl. My machine's hardware is pretty solid though so that may impact things. I haven't yet tried it on mac yet. |
Owner
|
That works for me. Thank you! If you want to test it on Mac, ok, otherwise I'm fine if you want this merged. |
Contributor
Author
|
I've been able to run this on an M1 MBP consistently without any issues. Ran this a few times:
Good to merge. :) |
Owner
|
Thanks for the contribution! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that this test wasn't passing for me when running things earlier. If there's too much timing variance in execution it can throw false-positives at least in part due to the way the test is asserting correctness.
The current flow of the test is:
Even though the spinner successfully restarted the test can fail if the count is off and (I think) can also be exacerbated by ANSI codes.
I had done some larger WIP testing where I would strip the output of control characters with the idea being to compare the output spinner characters directly. Doing something like that wouldn't totally address for variance still. Changing to check that the subset of symbols written after the restart also exists in the original run could help. Or perhaps simply that there were even any characters written after restart?