Update 1-connecting.mdx #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation should mention supported feature. brianc/node-postgres#2513
|
Hey! A preview of the changes is deployed on netlify to take a look at! :) Built with commit 80f61e0 https://deploy-preview-126--hopeful-clarke-f36d36.netlify.app |
|
Replace the double spaces at sentence end with single spaces and remove the extra newlines at the top/bottom of the sample code block to match the rest of the README. Otherwise, looks good to me. 👍 |
Collaborator
|
Is it possible to make this a more realistic example? It doesn’t have to be complete/runnable. |
More realistic example.
Contributor
Author
|
Thanks for your feedback! Sugggestions implemented in the update. |
Collaborator
|
Thank you! |
|
Yes that's much nicer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation should mention supported feature.
brianc/node-postgres#2513