Skip to content

chore: automatically replace var with let or const#3338

Closed
DavideViolante wants to merge 8 commits into
brianc:masterfrom
DavideViolante:master
Closed

chore: automatically replace var with let or const#3338
DavideViolante wants to merge 8 commits into
brianc:masterfrom
DavideViolante:master

Conversation

@DavideViolante

Copy link
Copy Markdown
Contributor
  • add eslint rule no-var
  • add eslint rule prefer-const
  • run npm run lint --fix to automatically fix the code

Note: I didn't fix any code manually, just ran eslint.

@brianc

brianc commented Jan 17, 2025

Copy link
Copy Markdown
Owner

I really like this...I'm a bit worried about breaking other PRs so lemme go through & merge a few, then I'll merge this. Any additional outstanding PRs should be able to aut-fix themselves w/ yarn lint:fix which is 👍

@DavideViolante

Copy link
Copy Markdown
Contributor Author

Resolved the conflicts, mergiable again.

@DavideViolante

Copy link
Copy Markdown
Contributor Author

Resolve conflicts
cc @brianc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants