Skip to content

Add config.query_timeout for query()#2655

Closed
Paxa wants to merge 1 commit intobrianc:masterfrom
Paxa:master
Closed

Add config.query_timeout for query()#2655
Paxa wants to merge 1 commit intobrianc:masterfrom
Paxa:master

Conversation

@Paxa
Copy link

@Paxa Paxa commented Nov 17, 2021 

client.query('select pg_sleep(10)', {query_timeout: 5})
  .then(...)
  .catch(error => { e.message == 'Query read timeout' })

Solve #2652

@brianc
Copy link
Owner

brianc commented Nov 17, 2021

thanks for the PR! Could you rebase on current master as I've re-enabled CI (travis ci kept breaking). And then if you could please write a quick integration test for this so we can be sure it will continue to work in the future!

@Paxa
Copy link
Author

Paxa commented Jul 17, 2022

Hi, thanks for reply, I'm afraid I don't have time to bring this PR to the right shape

Feel free to continue where I left

@Paxa
Copy link
Author

Paxa commented Sep 3, 2023

Applied to lastest master Paxa@03630e1

@srieding srieding mentioned this pull request Oct 6, 2023
Merged
@eladchen
Copy link

eladchen commented Mar 22, 2024

@brianc What's needed for this to be released?

@brianc
Copy link
Owner

brianc commented Mar 28, 2024

Apologies. Been crazy spinning down my current job...I'll try to get this released today or tomorrow. Going forward, after a few weeks of vacation, you can expect much more prompt responses here.

@charmander charmander closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Paxa @brianc @eladchen @charmander