Prep for v3.0.1 to temporarily address escape_utils deprecation warning#93
Merged
brettchalupa merged 7 commits intomainfrom Oct 14, 2022
Merged
Prep for v3.0.1 to temporarily address escape_utils deprecation warning#93brettchalupa merged 7 commits intomainfrom
brettchalupa merged 7 commits intomainfrom
Conversation
It appears to have changed, although I truthfully don't understand why that exactly is other than maybe dependencies changing and stuff. I wish this commit message was better but I'm still new to this codebase.
Adding myself as I intend to maintain the gem
… being deprecated It can be removed once gjtorikian/html-pipeline#365 is released in a gem. It may be possible to remove escape_utils at that point too. Temporarily relieves this warning: ``` EscapeUtils.escape_html is deprecated. Use GCI.escapeHTML instead, it's faster ```
Webrick was removed from the Ruby stdlib in late 2020 (see https://bugs.ruby-lang.org/issues/17303 & ruby/ruby#3729). This adds it as a development dependency for starting up the simple web server for the sample project. Webrick seems like a fine fit for a simple server like this.
For me maintaining the project now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets the project slightly updated for maintainership by me and a v3.0.1 release motivated by (temporarily) addressing this deprecation warning when generating the docs:
h/t and thanks to @gjtorikian for their work on this gem for many years!
What's to come
Some upcoming work on my mind for this gem:
sassgem—either moving to no Sass,sassc, ordartsassTo those watching, please let me know if there's anything you'd like to see by opening an issue.